2nd chunk: From 95a73bbc9bd65602a0f9411469ab511bc80a01d0 Mon Sep 17 00:00:00 2001 From: Till Kamppeter Date: Wed, 3 Oct 2018 15:13:00 +0200 Subject: Call QMessageBox constructors of PyQT5 with the correct parameters Bug-Debian: https://bugs.debian.org/912768 Bug-Ubuntu: https://bugs.launchpad.net/bugs/1745383 Index: ui/devmgr4.py --- ui/devmgr4.py.orig +++ ui/devmgr4.py @@ -1226,7 +1226,7 @@ class DevMgr4(DevMgr4_base): opt_plugin = d.plugin == PLUGIN_OPTIONAL hplip_conf = ConfigParser.ConfigParser() - fp = open("/etc/hp/hplip.conf", "r") + fp = open("${SYSCONFDIR}/hp/hplip.conf", "r") hplip_conf.readfp(fp) fp.close() @@ -1422,7 +1422,7 @@ class DevMgr4(DevMgr4_base): QMessageBox.critical(self, self.caption(), self.__tr("Unable to find an appropriate su/sudo utility to run hp-plugin.

Install kdesu, gnomesu, or gksu.

"), - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) else: @@ -2842,7 +2842,7 @@ class DevMgr4(DevMgr4_base): if utils.which('hp-setup'): cmd = 'hp-setup -u' else: - cmd = 'python ./setup.py --gui' + cmd = '${MODPY_BIN} ./setup.py --gui' log.debug(cmd) utils.run(cmd) @@ -2854,7 +2854,7 @@ class DevMgr4(DevMgr4_base): x = QMessageBox.critical(self, self.caption(), self.__tr("Annoying Confirmation: Are you sure you want to remove this device?"), - QMessageBox.Yes, + QMessageBox.Yes |\ QMessageBox.No | QMessageBox.Default, QMessageBox.NoButton) if x == QMessageBox.Yes: @@ -2949,7 +2949,7 @@ class DevMgr4(DevMgr4_base): QMessageBox.critical(self, self.caption(), error_text, - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) @@ -2958,7 +2958,7 @@ class DevMgr4(DevMgr4_base): QMessageBox.warning(self, self.caption(), msg, - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) @@ -3115,7 +3115,7 @@ class ScrollTestpageView(ScrollView): QMessageBox.information(self, self.caption(), self.__tr("

A test page should be printing on your printer.

If the page fails to print, please visit http://hplip.sourceforge.net for troubleshooting and support."), - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) @@ -3130,7 +3130,7 @@ class ScrollTestpageView(ScrollView): QMessageBox.critical(self, self.caption(), error_text, - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) @@ -3272,7 +3272,7 @@ class ScrollColorCalView(ScrollView): QMessageBox.information(self, self.caption(), self.__tr("

A test page should be printing on your printer.

If the page fails to print, please visit http://hplip.sourceforge.net for troubleshooting and support."), - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton) @@ -3287,7 +3287,7 @@ class ScrollColorCalView(ScrollView): QMessageBox.critical(self, self.caption(), error_text, - QMessageBox.Ok, + QMessageBox.Ok |\ QMessageBox.NoButton, QMessageBox.NoButton)